search

ns1 / nsone-python

NS1 Python SDK
https://nsone.net
MIT License
19 stars 20 forks source link

Added a get request to monitoring/jobs in order to enable monitor que… #6

Closed amirwollman closed 8 years ago

amirwollman commented 8 years ago

…ries.

Under this branch added two modules: List and Retrieve.

pashap commented 8 years ago

Hi @amirwollman, thanks for the PR! I left a few comments, but overall this is awesome. Let me know what you think and we can get this PR merged.

amirwollman commented 8 years ago

So I've made the changes, sorry for the mess, I was given a deadline at work to get this working so I didnt quite do a 'clean job' so to speak.. I tried to correct some of my previous errors but if you notice any others let me know and I'll get to work on these as well.

amirwollman commented 8 years ago

I only now saw your other comment. I've changed the method's name to monitorsjob, (tried to stick to the datafeed pattern) but this is also changeable if needed.

pashap commented 8 years ago

@amirwollman I left two small comments, but itll be good to merge after.

pashap commented 8 years ago

Thanks for the PR @amirwollman, merging now. No need to worry about the CI fail, fixing that now.