nsacyber / WALKOFF-Apps

WALKOFF-enabled applications. #nsacyber
https://nsacyber.github.io/WALKOFF
Creative Commons Zero v1.0 Universal
142 stars 41 forks source link

Updated create and append actions to emit newlines #12

Closed astrohart closed 5 years ago

astrohart commented 5 years ago

Updated the create and append actions to emit '\n' after each line. I am a bit concerned about this fix only in that the line endings are Linux-specific, and potentially serves to break the "cross-platformedness" of WALKOFF...I am not 100% sure what the further refinement is, but this seems like a step in the right direction.

astrohart commented 5 years ago

I am going to close this pull request, as I noticed that it is a platform-specific fix, and I also went and looked at which branches this pull request is being done against, and it's being done against the master branch of the destination repo, when guidelines suggest to submit pull requests to development branch. I will also post an issue so that the commit can be tied to a specific issue.