search

nsacyber / WALKOFF

A flexible, easy to use, automation framework allowing users to integrate their capabilities and devices to cut through the repetitive, tedious tasks slowing them down. #nsacyber
https://nsacyber.github.io/WALKOFF/
Other
1.2k stars 222 forks source link

Configuration isn't initialized in time to allow custom host and port #183

Closed alpal closed 6 years ago

alpal commented 6 years ago

Hi all,

Just had a quick look at WALKOFF. It might be due to my lack of experience with the tool, but it seemed like the following was an issue:

  1. Clean install
  2. Login to UI
  3. Change settings to listen on public interface (not just loopback) and change port
  4. Restart WALKOFF
  5. The settings are present but not applied at launch
  6. It seems like the configuration object isn't initialised before the params are used for host and port, so the settings are there in the json config, and they are correctly loaded but the host and port app setup happens before that occurs

It's quite possible I've missed something, but seemed like an issue - I could work around it by calling the config initialize method closer to the top of main

coreyjrobins commented 6 years ago

Hi alpal,

Thanks for pointing this out! We just pushed out a new release, v0.5.2, that should fix this issue. It looks like you were right -- we were not initializing the config before starting the server.

JustinTervala commented 6 years ago

Closing due to inactivity