Closed astrohart closed 4 years ago
Am not sure what it is saying about `ModuleNotFoundError: No module named 'redis'
.
I have redis installed, FYI:
walkoff@nsacyber:~/nsacyber/WALKOFF$ redis-cli
127.0.0.1:6379> ping
PONG
127.0.0.1:6379> exit
I did
$ sudo python3 -m pip install msgpack
$ sudo python3 -m pip install zmq
$ sudo python3 -m pip install redis
$ sudo python3 setup_walkoff.py
And then it installed. It has become my understanding that, on Ubuntu Desktop 18.04 LTS, there is such a heavy-handed preference in the OS for the python
command to call the python2 executable, and pips for both versions of Python are on the system, that I have to be explicit about which Python's pip
I mean. Still, should the msgpack
and zmq
modules be added to the requirements.txt
file?
This is because pip was unable to update PyYAML on your system:
Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
Changes to be made to setup_walkoff.py to address the issues raised:
My only disagreement is using sudo with pip. A Python environment manager (e.g. venv, pyenv, conda, etc.) should be used instead as recommended in the readme. The --user
flag for pip can also be used to direct pip to install packages to the user's home directory instead of a system directory, which doesn't require sudo (I can add this to the readme).
Using sudo with pip causes root to own the installed packages, and can also present a security issue.
Shouldn't the required packages just be added to requirements.txt
?
They are in requirements.txt. However if the pip installation fails, the setup continues anyways, and fails when it checks if redis exists. That's what I was referring to with "Better error handling to stop the setup script from proceeding if there are errors in pip install."
i guess I was confused because I was not following the readme, rather, following the Overview video's instructions on installing natively, found at: https://nsacyber.github.io/WALKOFF/vid/overview.mp4
Is there a script somewhere to properly configure a fresh, e.g., Ubuntu VM properly with the pre-reqs, so that setup_walkoff.py will work all the way through?
OS: Ubuntu Desktop 18.04 LTS Cloned latest from
master
at 1322 hrs on 26 Feb 2019Installation failed due to missing modules. Did I not catch all the necessary pre-reqs? This is with the latest
setup_walkoff.py
.