search

nsand / tab-glutton

Google Chrome tab management extension
MIT License
10 stars 4 forks source link

Themes and playing media icon. issue #38 #40

Closed shapkarin closed 3 years ago

shapkarin commented 4 years ago

38

nsand commented 4 years ago

Thanks for all the hard work on this, @shapkarin . I should have some time to look at the PR over the weekend.

shapkarin commented 4 years ago

@nsand OK, feel free to share yours thoughts

shapkarin commented 4 years ago

ping

nsand commented 4 years ago

Hey, @shapkarin Sorry work has been crazy lately and some RL things have popped up on top of that. I'll try reviewing this soon.

shapkarin commented 4 years ago

Got that. Thanks for the answer. Maybe I will add tests to this repo later.

shapkarin commented 4 years ago

@nsand Hi, I recently found that with a real big list styled-components performs slower than previous tab-glutton version. I think I need to add this optimization https://github.com/nsand/tab-glutton/issues/39 to the current PR.

nsand commented 4 years ago

Thanks for considering perf in this! I’ll have some time this weekend to take a look.

nsand commented 4 years ago

Hey, @shapkarin. I started looking at the changes and things are looking good so far. I haven't worked with styled-components yet, so I'm going to brush up on them a bit before continuing on. But just wanted to thank you for your patience while I review this.

shapkarin commented 4 years ago

It looks like it's just a higher-order component. But I still think that we need to add something like react-window to produce the next stable release.

shapkarin commented 4 years ago

I will try to find time for #39 too.. and fell free to help me with that

shapkarin commented 3 years ago

Hello @nsand can you please recheck this PR and approve with my changes extension still has enough performance for the new release. For the next one release I will find time to close the #39 with a new PR.

shapkarin commented 3 years ago

Hello. It's about half of year I use my fork and don't get any problems with performance. I guess that my PR is fine. Please have a look.

nsand commented 3 years ago

Hello. It's about half of year I use my fork and don't get any problems with performance. I guess that my PR is fine. Please have a look.

Thanks @shapkarin . I'm so sorry for this taking so long to get merged in. I appreciate your persistence and contribution! I hope you're doing well and staying healthy.

shapkarin commented 3 years ago

thanks