search

nsanta / fbgraph

Facebook Open Graph API in Ruby
MIT License
324 stars 40 forks source link

Fixed specs and constructor #16

Closed massive closed 14 years ago

massive commented 14 years ago

Hi,

I've just fixed the specs in my fork of the fbgraph. I've also re-added the ability to give :token parameter in the FBGraph::Client constructor since it has vanished in the commit 2807fbdfe36bdcd07fbb2d1115a46ef1525fabd3.

Naturally I'm not 100% sure whether the interface change was intentional, but at least it broke my application, many of the included specs, and it wasn't documented anywhere.

Note that I'm only using fbgraph to fetch data from the facebook. Therefore publishing and deleting is tested only manually and with rspec, and not in actual production environment.

nsanta commented 14 years ago

Yes, i see that now, not sure why i deleted that line of code. Maybe are ghosts on my house :P (ghosts that has the appareance of my daughter :D). i will take a look and fix quickly

massive commented 14 years ago

Ok, great. Check out the spec fixes too if you have time!

nsanta commented 14 years ago

applied to master.

Thanks for your work

nsanta commented 14 years ago

closed