search

nsanta / fbgraph

Facebook Open Graph API in Ruby
MIT License
324 stars 40 forks source link

SSL exception in faraday 0.6.0 and some security #49

Closed pwnall closed 13 years ago

pwnall commented 13 years ago

Hi again, Nicolas!

I've "bundle update"d my applications recently, and I started getting exceptions due to SSL certificate validation. It's a mess in ruby's OpenSSL / Net::HTTPS library, and people's wrappers didn't seem to make it much better.

I fixed the exception by adding a curl's CA bundle, and by wiring it into oauth2. Then I took advantage of the opportunity to enable certificate verification in RestClient. This removes the possibility of man-in-the-middle attacks between the Rails application server and Facebook (improbable, but still).

Please consider pulling in the change when you get a chance!

Thank you so much for the awesome gem! Victor

nsanta commented 13 years ago

Thanks for this update. Saved my life!.

BTW: Released 1.8.0 with your contributions!

pwnall commented 13 years ago

Thank you for answering so fast!

I'm glad I could help. I found your gem immensely useful!