Get chrome version from fileinfo when on windows

nsapa / fanfictionnet_ff_proxy

fanfictionnet_ff_proxy: an experimental "proxy" for fanfiction.net piloted by FanFicFare

CeCILL Free Software License Agreement v2.1

22 stars 3 forks source link

Closed TheCakeIsNaOH closed 3 years ago

TheCakeIsNaOH commented 3 years ago

Fixes: #6

Gets fileinfo directly from the .exe instead of trying to use --version.

Works with both Chromium and Chrome on Windows.

nsapa commented 3 years ago

Hi,

Thank you for your patch but I have $dayjob-inspired nightmare about COM and Python. I prefer parsing the pe file.

Best regards, NS

TheCakeIsNaOH commented 3 years ago

Ah, neat, I didn't know that there was a python lib for working with PE files.

Thanks for the quick fix.