search

nsarno / knock

Seamless JWT authentication for Rails API
MIT License
2.07k stars 253 forks source link

Is this project abandoned? #237

Closed jalberto closed 4 years ago

jalberto commented 5 years ago

I love the simplicity of this gem, but is getting outdated related to JWT and Rails itself. There are some small PRs that will mitigate this.

nickhall commented 5 years ago

Per the readme..

Is this gem going to be maintained?

Yes.

Oh...

jalberto commented 5 years ago

then maybe @nsarno is having some issues or requires help?

nsarno commented 5 years ago

@nickhall every time I arrive on this page, I stare at this line for 30s and consider committing to erase it then just proceed to back away slowly and pretend it doesn't exist for the next 3 months. Excuse my foolishness, I was young and pretentious. But feel free to fork of course...

then maybe @nsarno is having some issues or requires help?

@jalberto Thank you. I would be more than happy to onboard and add as a collaborator people willing to help! Let me know if that's you and I'll reach out to you directly outside of this issue.

nickhall commented 5 years ago

Forgive my snarkiness. There are a number of pull requests that have gone unanswered so I assumed the worst. If you really do just need help I'd be glad to take a look as well!

jalberto commented 5 years ago

@nsarno I am willing to help :) I don't promise to be able to dedicate lot of time, but enough to review some PRs and help to keep this nice lib alive :)

bjensen commented 5 years ago

So what is the alternative? Currently Im using just the jwt gem with auth0 but rspec request specs seam to be a bit of a pain..

jalberto commented 5 years ago

I plan to begin some review work and updates as soon my current work peak is back to normal.

Meanwhile feel free to use PRs to address your issues.

El sáb., 6 abr. 2019 10:42, Brian Jensen notifications@github.com escribió:

So what is the alternative? Currently Im using just the jwt gem with auth0 but rspec request specs seam to be a bit of a pain..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nsarno/knock/issues/237#issuecomment-480486818, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGGV4MP2dsyInh5aV6iHY53qEiPPh6oks5veF3wgaJpZM4bHt62 .

sshaw commented 5 years ago

@jalberto would be good to do a release with this fix. Work is already done.

This caused some problems for me today, i.e., the authentication was failing because an error related to a bug in the code was being swallowed. 😿

kwent commented 5 years ago

@jalberto please give us some news or try to find a new maintainer 🙏🙏