Move PyPredict custom exception definition to predict.c

nsat / pypredict

Spire port of predict open-source tracking library

GNU General Public License v2.0

64 stars 17 forks source link

Move PyPredict custom exception definition to predict.c #6

Closed jtrutna closed 9 years ago

jtrutna commented 9 years ago

Also added exceptions on failure cases in C code.

@mconst-nanosatisfi

mconst-spire commented 9 years ago

Okay, other than the comments above (which are all minor), this looks good to me.

jtrutna commented 9 years ago

Comments addressed. Could you take a quick look at the quick_predict function and make sure there aren't any lurking bugs with my use of a local goto?

mconst-spire commented 9 years ago

Cool, this looks good to me. (In theory I think you're also supposed to free your new py_obs reference if the subsequent PyList_Append fails, but I can't imagine that ever being a problem in practice -- it's a tiny memory leak, and it'll only happen if you're already out of memory for other reasons. Manual memory management sucks.)