nschlia / ffmpegfs

FUSE-based transcoding filesystem with video support from many formats to FLAC, MP4, TS, WebM, OGG, MP3, HLS, and others.
https://nschlia.github.io/ffmpegfs/
GNU General Public License v3.0
196 stars 14 forks source link

autocopy STRICT never triggers for video streams #151

Closed mihaiush closed 6 months ago

mihaiush commented 6 months ago

This condition https://github.com/nschlia/ffmpegfs/blob/b95ece1418c633378d47ccc69eef2c7c1efeab1b/src/ffmpeg_transcoder.cc#L811 always evaluates the audio codec regardless if the codec type is audio or video. It always returns false for video streams.

nschlia commented 6 months ago

This is true, this is not the intended behaviour. I'll have to update that function. Thanks for pointing this out.

mihaiush commented 6 months ago

I have a patch, if you are interested I could make a MR.

nschlia commented 6 months ago

I have a patch, if you are interested I could make a MR.

That would be cool, of course the patch is welcome.