nseah21 / pe

0 stars 0 forks source link

Unable to add an event with symbols in its name #6

Open nseah21 opened 2 years ago

nseah21 commented 2 years ago

Description of bug:

Given that some events might have descriptions which encapsulate multiple sub-events, for example, a department store might have an event such as weekly clearance sale/new item promotions, the app should allow for department stores to enter such a description.

This might hinder the user who needs to encapsulate many of such events (with multiple subevents)

Steps to reproduce:

addEvent e/concert/musical/opera d/22/10/2000 t/11:00 p/112312

Screenshots:

image.png

soc-se-bot commented 1 year ago

Team's Response

Thank you for submitting this report, our design of event title is that it should be a short and descriptive phrase of the event, therefore, we think it's not so necessary to include special characters, such as "/" or "-" in the event title.

However, we understand your example that some events might have descriptions which encapsulate multiple sub-events, in this case, the problem can be solved by putting the main event title in event title, and put the sub-events in event purpose to serve as a complementary event description.

For example: this command can be used to deal with your example above addEvent e/concert d/22/10/2000 t/11:00 p/musical/opera in concert 112312

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > Thank you for submitting this report, our design of event title is that it should be a short and descriptive phrase of the event, therefore, we think it's not so necessary to include special characters, such as "/" or "-" in the event title.

I disagree. Most sale events today involve cardinal numbers in their titles -- one good example would be the 11.11 sale, which is so popular that it has inspired many similar "double-digit" sales for each month of the year. Another common sale is a clearance sale, where an appropriate event title could be "Clearance Sale -$5 off all items". It would be too restrictive to prevent the users (who manage a department store) from using such common symbols (i.e. numbers, periods and dashes) in their event titles.

However, we understand your example that some events might have descriptions which encapsulate multiple sub-events, in this case, the problem can be solved by putting the main event title in event title, and put the sub-events in event purpose to serve as a complementary event description. For example: this command can be used to deal with your example above addEvent e/concert d/22/10/2000 t/11:00 p/musical/opera in concert 112312

This does not seem like a good suggestion, as it violates the intention of the purpose field. It would be more intuitive to allow all the details referring to the description of an event to be encapsulated in the title field.

Ultimately, this feature could have been easily improved to allow for these special characters in the event title, since a similar functionality was implemented for the purpose field. However, since it was not implemented, the user is largely restricted when entering event titles, causing them to need to find other (unintuitive) alternatives as mentioned by the team.