nservant / HiC-Pro

HiC-Pro: An optimized and flexible pipeline for Hi-C data processing
Other
382 stars 183 forks source link

Possible mistake in digest_genome.py #429

Closed DavideBrex closed 3 years ago

DavideBrex commented 3 years ago

Running the script, If I set the "-r" flag equal to an enzyme name (e.g. hindiii), the program will halt with this message:

Find unexpected character in restriction motif.

I think the problem is here: https://github.com/nservant/HiC-Pro/blob/351471bde0bff2985ec40ee22934c3f03612b6e8/bin/utils/digest_genome.py#L144-L149

Where for nuc in list(set(cs)): should be insteadfor nuc in list(set(cseq)):

Let me know what you think please! and thank you for the amazing pipeline. Davide

nservant commented 3 years ago

Hi ! yes, indeed, I think you're right !

nservant commented 3 years ago

I'll fix that in the devel ! many thanks

nservant commented 3 years ago

done !