search

nsf-open / nsf

Repo for the NSF Site Redesign & Content Discovery project
https://nsf-demo.app.cloud.gov
GNU General Public License v2.0
4 stars 4 forks source link

Uninstall the Contact module #228

Closed fureigh closed 6 years ago

fureigh commented 6 years ago

(A proposed revision to #205.)

The Contact module is the core module that creates personal contact forms as well as the sitewide contact form. Because we're not currently using that functionality, we can turn it off by uninstalling the Contact module, which includes deleting its configuration files.

By handling #205 at the module level, we enable a future developer to reenable the module and have it work as expected, while slightly improving performance in the meantime (by not loading the Contact module on every page load even though it's not really being used).

cmc333333 commented 6 years ago

This isn't working for me locally (the contact link is present for all users). I suspect this needs an edit to core.extensions.yml.

fureigh commented 6 years ago

@cmc333333 Thanks for the feedback. I initially edited core.extensions.yml manually, but it got overwritten (with a contrary value) when I exported the site's configuration. 🤔 PR update forthcoming.

fureigh commented 6 years ago

Found the culprit: my change to bootstrap.sh hadn't come along for the ride. Ready for another look.

screen shot 2018-04-23 at 11 20 23 am
fureigh commented 6 years ago

@cmc333333 Thanks! And good call, let's do that. I believe the reason that file continues to be exported is that the recipients field has a value (the site owner). I'll check whether I can zero that out, and if I can't I'll just add that file back before merging.

cmc333333 commented 6 years ago

Aha! That'd do it. There's a line in bootstrap.sh that sets it which can probably be deleted

fureigh commented 6 years ago

👍 We could handle that conditionally, but for now I've simply deleted it. Care to take another look?