search

nsf / godit

A very religious text editor
MIT License
576 stars 77 forks source link

Correct rune width #5

Closed mattn closed 9 years ago

mattn commented 11 years ago

https://github.com/nsf/termbox-go/pull/21

I know runWidth is in also termbox-go. So if you mind this, please move it into some where. And I'll working to add utf8.RuneWidth() into unicode/utf8 after the release of go1.1

mattn commented 11 years ago

Ah, there are more problems. But I don't know termbox-go / godit well. Could you please handle this issue?

nsf commented 11 years ago

As for this patch, yeah, the stuff you've added solves drawing, but not cursor moving logic. I'll fix that as soon as termbox CJK support is added.

edited: On the other hand it should, but again, I'll check that out later. I don't remember how things should be done either. :D