Closed rikvdh closed 8 years ago
I'll merge it tomorrow. That missing semicolon commit is scary. It means you didn't even bother to compile the code and I'm not talking about testing it on many terminals with various output modes. Please, don't do that. I won't test your changes for you.
I can imagine. My first commit was too hasty, I wanted to commit and build my own application to test it. I'm also not very used to 'waf'. Perhaps it is a good idea to describe some basic tests in the README which must/can be performed. Without CI some procedures can be described and you can require for example screenshots with PR's.
In addition to #73, this is a tad less verbose.