nsh87 / receptormarker

Source for 'receptormarker' package for R: antibody receptor and phenotypic marker analysis
http://receptormarker.com
BSD 2-Clause "Simplified" License
4 stars 9 forks source link

Create cluster object and plotting #16

Closed catterbu closed 9 years ago

catterbu commented 9 years ago

The cluster object uses kmeans clustering and silhouette scores to determine optimal clustering. The plotting functions take this object and create plots such as a WSS plot, gap analysis plot, silhouette plot, and cluster membership box plot.

nsh87 commented 9 years ago

There were some errors when checking the built package on this PR, but I wasn't detecting them properly. It's fixed now, which is why your build check now fails. The fixes went into dev, so just rebase off of dev again before pushing any fixes. I think that should do it for the changes into dev for a bit (until we merge this PR).

catterbu commented 9 years ago

@nsh87 If it passes, everything should be ready.

nsh87 commented 9 years ago

Awesome plots! Finally got a chance to run them all. Really nice job, and the documentation is so much more helpful and comprehensive than 99% of the documentation I've ever seen. I opened a couple issues, we can fix them before v1. When you're fixing them just close them in your commit messages with Fixes #11 to close Issue #11, for example. The issues will be closed automatically when the commit gets merged into master.