Closed catterbu closed 9 years ago
Add the latest version of DbClust to Imports, should fix it. Looks like there's a cross reference, I imagine a link, in the NbClust documentation to it.
If that works the Import should really be in NbClust Description.
DbClust does not exist. Are you sure that it was not another name? I could not find it on CRAN and I tried it without a version number and devtools::check()
told me that it was not available.
Then you added a reference to DbClust
in your documentation :wink:
I swore loudly in my head when I read this. I do not know how you found this, but thanks.
It's all about deciphering the error message. Can you put PCA in a different PR/branch than this one?
Oh I forgot! How can I do that now?
I can't merge this until the ability to turn off NbClust's plotting is available. The NbClust plotting totally screws up the resulting plots from your wss_plot
and other functions.
I noticed that the package author isn't the same guy as the one where your PR is (https://github.com/cran/NbClust/pull/1) (actually, it's CRAN's repo, so that makes sense). That's unfortunate. I left a message on the actual author's website (https://sites.google.com/site/malikacharrad/research/nbclust-package) with a link to your PR requesting that he incorporate the changes. I'll email him and see what he says.
The other option: I checked out the license for NbClust. It's distributed under GPL-2 license, which is pretty open. So you could create your own function in our package - derived from NbClust but with your changes - and as long as
NbClust.R
That's an option, but maybe wait a day or two, I'm going to email the package author right now to see if he'll make the changes.
The NbClust guy hasn't responded... I know you had this thought already: might as well put your modifications of the code in our package. Good thing it's all open source. Just make sure to include as copy of the license file and your document your major changes in your NbClust.R, as per the GPL-2 license.
@nsh87 if this branch passes, then it and the other two pull requests that I have open should be ready.
By leveraging the
NbClust
package, determination of the optimal number of clusters is done by looking at 26 different metrics and choosing the most common one. Note: When runningdevtools::check()
, there was a warning regarding theNbClust
package. See below.Unknown package 'DbClust' in Rd xrefs