search

nsh87 / receptormarker

Source for 'receptormarker' package for R: antibody receptor and phenotypic marker analysis
http://receptormarker.com
BSD 2-Clause "Simplified" License
4 stars 9 forks source link

Minor fixes: lintr, Readme, and change where Slack notifications go #50

Closed nsh87 closed 8 years ago

nsh87 commented 8 years ago
  1. Travis was failing error checks simply because it was picking up a commented line as "code in a comment", which are supposed to be cleaned up and removed. Telling lintr to ignore that line fixed the issue.
  2. The Readme should also have included instructions about installing muscle (which also installs Biostrings) from Bioconductor before attempting to install the package or develop it. Developers joining the project and following the instructions on the Readme would not have muscle installed and so loading the package would fail.
  3. We created a new Slack team, and Travis notifications should go there rather than our old team/channel. Changed the notification key to make this happen.