nsh87 / receptormarker

Source for 'receptormarker' package for R: antibody receptor and phenotypic marker analysis
http://receptormarker.com
BSD 2-Clause "Simplified" License
4 stars 9 forks source link

Use NbClust package to determine best number of clusters #62

Closed catterbu closed 8 years ago

catterbu commented 8 years ago

This pull request adds a new method for determining the best number of clusters in multi_clust to use for a given data set. Specifically,

nsh87 commented 8 years ago

@catterbu: how are those unit tests for boolean data working out? let me know when this seems fully tested and ready to merge.

catterbu commented 8 years ago

@nsh87 Yeah, pretty much done. Had a weird last couple of days, but I think that I have everything figured out. I just have to dirty that data set I created, integrate the changes you just added via rebase, and then make sure that everything is good.

nsh87 commented 8 years ago

@catterbu: this isn't correct anymore, is it? It should say that it's chosen by majority rule using a bunch of different algorithms, right?

catterbu commented 8 years ago

@nsh87 the documentation for the multiClust object appears to have updated properly. Let me know if I missed something. Chris

On Mar 14, 2016, at 9:03 AM, Nikhil Haas notifications@github.com wrote:

@catterbu: this isn't correct anymore, is it? It should say that it's chosen by majority rule using a bunch of different algorithms, right?

— Reply to this email directly or view it on GitHub.

nsh87 commented 8 years ago

@catterbu: Not sure what this is referring to: "@nsh87 the documentation for the multiClust object appears to have updated properly. Let me know if I missed something."

catterbu commented 8 years ago

@nsh87 you had a comment about the docs needing to be updated. Maybe I misinterpreted it on my phone.

On Mar 14, 2016, at 9:42 AM, Nikhil Haas notifications@github.com wrote:

@catterbu: Not sure what this is referring to: "@nsh87 the documentation for the multiClust object appears to have updated properly. Let me know if I missed something."

— Reply to this email directly or view it on GitHub.

nsh87 commented 8 years ago

@catterbu: you had documented multiClust in two different functions (basically copying the documentation in one to the other). You updated one of them, but not the other. So rather than deal with this again when COMMUNAL is used, I'm just creating an actual class where the documentation for multiClust can live and it can just be referenced from whatever functions you want. I'll have to update some of the code since referencing slots in a class is done with @, not the typical indexing with [ ].

catterbu commented 8 years ago

@nsh87 got it.

On Mar 14, 2016, at 9:57 AM, Nikhil Haas notifications@github.com wrote:

@catterbu: you had documented multiClust in two different functions (basically copying the documentation in one to the other). You updated one of them, but not the other. So rather than deal with this again when COMMUNAL is used, I'm just creating an actually class where the documentation for multiClust can live and it can just be referenced from whatever functions you want. I'll have to update some of the code since referencing slots in a class is done with @, not the typical indexing with [ ].

— Reply to this email directly or view it on GitHub.

nsh87 commented 8 years ago

@catterbu: maybe I missed it, but did you generate a new multiClust object f_clust.rda for use in the unit tests, or is it still the old one?

catterbu commented 8 years ago

@nsh87 No! I forgot to look up how to do that.

On Mar 14, 2016, at 10:43 AM, Nikhil Haas notifications@github.com wrote:

@catterbu: maybe I missed it, but did you generate a new multiClust object f_clust.rda for use in the unit tests?

— Reply to this email directly or view it on GitHub.

nsh87 commented 8 years ago

@catterbu: it's just save(object_to_save, file="filename.rda"),then move it where you want to.