search

nsh87 / receptormarker

Source for 'receptormarker' package for R: antibody receptor and phenotypic marker analysis
http://receptormarker.com
BSD 2-Clause "Simplified" License
4 stars 9 forks source link

Fix "could not find function "aes" error on Cluster Membership olot #71

Closed nsh87 closed 8 years ago

nsh87 commented 8 years ago

Need to fix error caused by using ggplot instead of ggplot2 in f21e6091bb7c3c9681f47f21d6e14d9eae8525ba.

nsh87 commented 8 years ago

screen shot 2016-07-09 at 2 24 37 pm

nsh87 commented 8 years ago

@catterbu: we have to get more rigorous about testing...

nsh87 commented 8 years ago

I think this is why... but investigating.

nsh87 commented 8 years ago

@catterbu: when you're working w/ the package or testing, make sure you haven't done library(ggplot2) or any other package dependencies. looks like you had ggplot2 loaded in your local R so you weren't seeing this error, but aes and element_blank() needed to be referenced explicitly as being from ggplot2.

catterbu commented 8 years ago

That was precisely the problem. I think we should have tests for each plot that just check for errors or not if plotted. I cannot recall of that is there. Sorry about the bugs. Because of the limited time I guess I shortcut a few things. Will endeavor to be better in the future. :)

On Jul 9, 2016, at 2:44 PM, Nikhil Haas notifications@github.com wrote:

@catterbu: when you're working w/ the package or testing, make sure you haven't done library(ggplot2) or any other package dependencies. looks like you had ggplot2 loaded in your local R so you weren't seeing this error, but aes and element_blank() needed to be referenced explicitly as being from ggplot2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

nsh87 commented 8 years ago

No worries. Ya, we had tried the plotting thing...It's a good idea. I remember the issue was that kmeans is random and we didn't realize the seed was changing so the results were changing...

On July 10, 2016 10:06:54 AM catterbu notifications@github.com wrote:

That was precisely the problem. I think we should have tests for each plot that just check for errors or not if plotted. I cannot recall of that is there. Sorry about the bugs. Because of the limited time I guess I shortcut a few things. Will endeavor to be better in the future. :)

On Jul 9, 2016, at 2:44 PM, Nikhil Haas notifications@github.com wrote:

@catterbu: when you're working w/ the package or testing, make sure you haven't done library(ggplot2) or any other package dependencies. looks like you had ggplot2 loaded in your local R so you weren't seeing this error, but aes and element_blank() needed to be referenced explicitly as being from ggplot2.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/nsh87/receptormarker/issues/71#issuecomment-231599431