search

nsheff / LOLA

Locus Overlap Analysis: Enrichment of Genomic Ranges
http://code.databio.org/LOLA
70 stars 19 forks source link

PEP loading function for LOLA #35

Open joseverdezoto opened 4 years ago

nsheff commented 4 years ago

@joseverdezoto this is not passing the travis unit tests, can you look into that?

joseverdezoto commented 4 years ago

@nsheff could you look over the changes to the loadPEPdb function? I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally. It could also be that warnings were being treated as errors. Let me know if the current changes look good.

nsheff commented 4 years ago

I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally

this was running on travis, right? your local environment would be irrelevant...

joseverdezoto commented 4 years ago

@nsheff I made the suggested changes tested the function. The only thing I'm not sure of is how we'd include pepr as a dependency. I tried updating the DESCRIPTION file but that commit didn't pass the travis unit tests because pepr could not be installed