nsheff / LOLA

Locus Overlap Analysis: Enrichment of Genomic Ranges
http://code.databio.org/LOLA
71 stars 19 forks source link

Clarifications #6

Closed fhalbritter closed 9 years ago

fhalbritter commented 9 years ago

Tried to make the cryptic description of "userUniverse" a little clearer. Not sure it worked. Is this even correct? :-)

nsheff commented 9 years ago

Not quite...

the description is cryptic partly because the concept is a bit cryptic :). I'll work on that...

On 04/20/2015 03:48 PM, Florian Halbritter wrote:

Tried to make the cryptic description of "userUniverse" a little clearer. Not sure it worked. Is this even correct? :-)


    You can view, comment on, or merge this pull request online at:

https://github.com/sheffien/LOLA/pull/6

    Commit Summary

— Reply to this email directly or view it on GitHub https://github.com/sheffien/LOLA/pull/6.

nsheff commented 9 years ago

Actually this description is not correct...it does not have to be a superset (in particular it must not include all regionDB regions)

fhalbritter commented 9 years ago

Fair enough. I interpreted universe in a hypergeometric test kind-of manner. In any case, I think you'll need to explain better what you actually mean in the vignette!