nshian / nus-cs2113-pe

0 stars 0 forks source link

Application does not handle special requisites for NOC eligibility based on student's course of study #5

Open nshian opened 2 years ago

nshian commented 2 years ago

The application does not account for special pre-requisites required for NOC for certain courses of study e.g. for Computer Engineering students, CS2113 is a requirement before embarking on NOC but the application incorrectly outputs that the student can go on NOC despite not completing the module.

image.png

nus-se-bot commented 2 years ago

Team's Response

Pre-requisites is not part of our eligibility criteria.

We have previous mentioned that user need to check for the pre-requisites themselves.

Screenshot (77).png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The description given in the UG (the team's screenshot) regarding the user's responsibility to check for pre-requisites is for MODULES not school programmes. NOC should not be categorised as a module. The bug reported here is simply that the criteria being used to check for NOC eligibility is too blunt and not refined enough as it does not cover special cases of NOC eligibility such as Computer Engineering undergraduates having to fulfil CS2113 before embarking on NOC. Clearly, this NOC checking feature is incomplete and not comprehensive enough, and is essentially rendered useless for Computer Engineering undergraduates for example. Note that this is also true for the rest of SoC (see picture).

image.png

On the other hand, if the team wishes to argue that the description given also includes the user's responsibility to check for pre-requisites for school programmes and not just modules, then what is the use of such a checker within the application since students will have to go onto the school website to check anyway?