search

nshmura / dsio

Command line tool for Google Cloud Datastore, written in Go
70 stars 13 forks source link

remove manual confirmation after each batch (or make it optional) #37

Open ththvseo opened 6 years ago

ththvseo commented 6 years ago

both query and upsert interactively ask the user for confirmation after each batch of entries: https://github.com/nshmura/dsio/blob/bd941641acb0201322c8a789acee77a3b7a584d5/action/query.go#L310 https://github.com/nshmura/dsio/blob/bd941641acb0201322c8a789acee77a3b7a584d5/action/upsert.go#L79

this is kind of silly, especially when batch-processing (large amounts of) data.

it should be removed or at least made optional.

if the intention is to make interactive use more covenient, it could maybe be enabled/disabled automatically enabled only for interactive sessions: https://rosettacode.org/wiki/Check_output_device_is_a_terminal#Go

nshmura commented 6 years ago

👍 the url is very informative。 I will consider about batch-processing.

ggalmazor commented 6 years ago

I would add to this an option to always overwrite output file to avoid having to interactively answer that too.