fix: Broken session output after first start

nshou / elasticsearch-kibana

Simple and lightweight docker image for previewing Elasticsearch and Kibana.

https://hub.docker.com/r/nshou/elasticsearch-kibana

MIT License

46 stars 24 forks source link

fix: Broken session output after first start #26

Closed txj-xyz closed 10 months ago

txj-xyz commented 11 months ago

This PR fixes and cleans up a few things.

Fixed an issue with the Kibana password not being output on first launch on some Arch systems.
Added compatibility for Kubernetes
Fixed Syntax issue with entrypoint.sh#L150
Added more clear README.md instructions on how to manually reset the password if needed

Extra usage variables and how to reset the password if for some reason you do not see that output when the program starts.

Also I'd suggest updating the Docker image on your page here: https://hub.docker.com/r/nshou/elasticsearch-kibana

txj-xyz commented 11 months ago

I will fix these some time this week, will leave this open for now

txj-xyz commented 10 months ago

Pretty much ready now.

txj-xyz commented 10 months ago

Ready for merge into master and DockerHub update.

I've tested with the changes on my fork in production and everything passes PCI DSS v4 and CIS scans on Kubernetes!

@nshou Let me know if you have any questions, all nit's were fixed! :) happy holidays

nshou commented 10 months ago

Sorry! I was out for a long vacation. Looking.

nshou commented 10 months ago

What is ELASTIC_NEW_PASSWORD in the dockerfile for? It's overwritten with the random password anyways. But I'm merging it in any case to unblock. Thank you again!