Open itcarroll opened 1 month ago
Nice catch! Why isn't our type checker catching this though?
I love pathlib though, should we update download()
to always return Path
s? :)
If you want to be fancy, you could return the same type given to you in the local_path
argument.
I like the idea of returning a list of Path objects. I think this would avoid cross platform issues.
The download docs say that the return value shall be a list of strings. When running
in_region
however, the result is a list ofpathlib.PosixPath
objects.The last assert raises an exception.