search

nsidc / qgreenland-plugin

Other
4 stars 2 forks source link

Remember the last chosen folder #14

Closed ghtmtt closed 3 years ago

ghtmtt commented 3 years ago

@MattF-NSIDC could you please try and confirm? Thanks!

MattF-NSIDC commented 3 years ago

Linking issue #8

Woops, I mean issue #9

MattF-NSIDC commented 3 years ago

@ghtmtt Can you please also add Trey Stafford trey-stafford to all reviews going forward? Thanks!

trey-stafford commented 3 years ago

Hey @ghtmtt I just tried this branch out locally and expect to see my previously selected folder when re-loading the plugin, or re-opening QGIS. It does not appear as though the download path is being saved between sessions? Is there a file the download folder setting is being written to?

Should we expect QgsSettings to persist between QGIS sessions?

After re-loading the plugin, I expect to see my previous download path populated in the Folder selection on the downloads page. See:

latestScreen

ghtmtt commented 3 years ago

Should we expect QgsSettings to persist between QGIS sessions?

yes. During the debugging, so when reloading the plugin (AKA recompiling it) then the QgsSettings object is gone :)

After re-loading the plugin, I expect to see my previous download path populated in the Folder selection on the downloads page.

OK no problem to address this

MattF-NSIDC commented 3 years ago

yes. During the debugging, so when reloading the plugin (AKA recompiling it) then the QgsSettings object is gone :)

We also observed that the setting was not saved when closing and re-opening QGIS. Is that expected, or is it possible we've missed a setup step? Maybe we can jump on a screen share to discuss? Tomorrow 2021-10-28 9AM MT / 5PM IT works for us. Friday works for Trey, but I won't be working then.

ghtmtt commented 3 years ago

We also observed that the setting was not saved when closing and re-opening QGIS. Is that expected, or is it possible we've missed a setup step? Maybe we can jump on a screen share to discuss? Tomorrow 2021-10-28 9AM MT / 5PM IT works for us. Friday works for Trey, but I won't be working then.

sorry tomorrow I'm busy with a training the whole day. Tomorrow 5PM IT time works for me, let me know if you still want to make a screen share discussion.

In my case, when closing and reopening QGIS the folder chosen in the previous sessions is remembered correctly, not when the plugin is reloaded (but that's correct because the QgsSettings object is re-created from scratch).

ezgif com-gif-maker

MattF-NSIDC commented 3 years ago

When we shutdown and re-start QGIS, we actually don't see the plugin in the GUI until we reload it. I think a screen share is a good idea to demonstrate what we're seeing!

trey-stafford commented 3 years ago

@ghtmtt lets plan to meet tomorrow (5PM your time) for a screen-share. Maybe I need to setup the plugin in QGIS differently. Thanks!

ghtmtt commented 3 years ago

OK let's have the screen share tomorrow! Same jitsi channel as always!