nsidc / qgreenland

Source code for generating the QGreenland package hosted at https://qgreenland.org/
https://qgreenland.readthedocs.io
Other
36 stars 9 forks source link

Fix copyright/logo text style #774

Closed MattF-NSIDC closed 10 months ago

MattF-NSIDC commented 10 months ago

On my computer the QGreenland logo is less readable now than it was, maybe we could cut the buffer down by half or more?

Slack Message

mfisher87 commented 10 months ago

Here's the patch to the project file after making the font changes in QGIS: https://gist.github.com/mfisher87/0d0fc7cc5cbb27c7c32474a317e0cdd0

What a mess, but I think we can extract the important parts. Search for v3.0.0 to find our copyright label.

mfisher87 commented 10 months ago

Here's what the problem looks like image

mfisher87 commented 10 months ago

After the patch above image

mfisher87 commented 10 months ago

This minimal patch fixes it for me:

diff --git a/qgreenland.qgs b/qgreenland.qgs
index 88355e7..4dc1344 100644
--- a/qgreenland.qgs
+++ b/qgreenland.qgs
@@ -226669,10 +226669,10 @@ https://data.mendeley.com/datasets/c4xj5rv6kv/2</abstract>
   <properties>
     <CopyrightLabel>
       <Enabled type="int">1</Enabled>
-      <Font type="QString">&lt;text-style>&lt;text-buffer bufferColor="250,250,250,255" bufferJoinStyle="128" bufferSize="1" bufferDraw="1" bufferSizeUnits="MM" bufferOpacity="1" bufferBlendMode="0" bufferSizeMapUnitScale="3x:0,0,0,0,0,0" bufferNoFill="1"/>&lt;/text-style></Font>
+      <Font type="QString">&lt;text-style fontFamily="Open Sans" namedStyle="Regular">&lt;text-buffer bufferColor="250,250,250,255" bufferJoinStyle="128" bufferSize="1" bufferDraw="1" bufferSizeUnits="MM" bufferOpacity="1" bufferBlendMode="0" bufferSizeMapUnitScale="3x:0,0,0,0,0,0" bufferNoFill="1"/>&lt;/text-style></Font>
       <Label type="QString">QGreenland v3.0.0rc1 © NSIDC 2023
 https://qgreenland.org | https://github.com/nsidc/qgreenland/</Label>
-      <MarginH type="int">0</MarginH>
+      <MarginH type="int">1</MarginH>
       <MarginV type="int">0</MarginV>
       <Placement type="int">0</Placement>
     </CopyrightLabel>
@@ -226691,8 +226691,8 @@ https://qgreenland.org | https://github.com/nsidc/qgreenland/</Label>
     <Image>
       <Enabled type="int">1</Enabled>
       <ImagePath type="QString">qgreenland.png</ImagePath>
-      <MarginH type="int">4</MarginH>
-      <MarginV type="int">8</MarginV>
+      <MarginH type="int">1</MarginH>
+      <MarginV type="int">12</MarginV>
       <Placement type="int">0</Placement>
       <Size type="int">24</Size>
     </Image>
mfisher87 commented 10 months ago

Here's what it looks like if we switch to bold, I think this is my favorite: image

twilamoon-science commented 10 months ago

This text does open at a fairly big size in my window. The size can be controlled by zoomining in/out with the "Magnifier", but I remember in Denmark we have a number of folks with computers that open this quite big. We might want to default on a slightly smaller size.

MattF-NSIDC commented 10 months ago

I think it might be opening at different sizes on different computers because those computers have different system fonts. This is a total guess. In addition to the changes to specify Open Sans Regular above, we can also explicitly set the font to 12pt and that should give a consistent small-but-readable experience on all systems. I think :)

We can test by uploading a qgreenland.qgs file to GitHub, and you can replace yours with that one and see what it looks like.

(fontSize="12")

MattF-NSIDC commented 10 months ago

qgreenland.qgs.zip

You'll have to unzip it, as GitHub only supports certain filetypes.

MattF-NSIDC commented 10 months ago

Twila tested, looks good!

EDIT: Trey tested, looks good