nsidc / usaon-benefit-tool

Application for configuring USAON Benefit Tool value tree analysis surveys and gathering input from respondents
https://usaon-benefit-tool.readthedocs.io/
MIT License
0 stars 3 forks source link

Assessment and object library description character limit is too small - increase 8x #292

Closed hazelshapiro closed 4 months ago

hazelshapiro commented 5 months ago

Increase character/word limit on assessment description. This also applies to objects. New Assessment > Description. New Observing System/Data Product/Application/Societal Benefit Area > Description.

Increase 8x

hazelshapiro commented 4 months ago

@Sherwin-14 if you're interested, this might be another one to tackle. I would want to know from @MattF-NSIDC if it will cause issues with storage space, though, and, Matt, what you would recommend for a new character limit. If these are preset fields, like in a Google form, I'd recommend changing it from a "short answer" to a "long answer" field. Does that make sense?

mfisher87 commented 4 months ago

@hazelshapiro this doesn't cause me any concerns storage space, let's go with whatever limit feels appropriate to you. Does 4x sound OK? We can choose any length we want.

hazelshapiro commented 4 months ago

Great, in that case, let's do 5x so we can accommodate a few longer answers if needed

mfisher87 commented 4 months ago

5x

How about 8x? I like multiples of 2 ;)

@hazelshapiro important to note, now that we're in production we must set up data migrations before our next release. The time cost might be a day, two on the outside. This ticket impacts the data model (see labels). We can only release changes that don't impact the datamodel without needing a migration.

Edit to add: Future migrations won't re-incur the same setup cost.

Sherwin-14 commented 4 months ago

Yes I would love to! Will take a look into it.

mfisher87 commented 4 months ago

Resolved in #301

Thank you @Sherwin-14 !

hazelshapiro commented 4 months ago

Thank you!

hazelshapiro commented 4 months ago

5x

How about 8x? I like multiples of 2 ;)

@hazelshapiro important to note, now that we're in production we must set up data migrations before our next release. The time cost might be a day, two on the outside. This ticket impacts the data model (see labels). We can only release changes that don't impact the datamodel without needing a migration.

Edit to add: Future migrations won't re-incur the same setup cost.

Does this mean that this change won't be deployed until we have our next dedicated development time? Just want to make sure I understand. What about deploying the gray nodes update? @mfisher87

mfisher87 commented 4 months ago

Correct, this change would be impossible to deploy before we figure that problem out. The gray node change is possible to deploy before then, but it does take a nominal amount of time.