Add the ability to configure the notes on the newly cloned VM

[rylarson]

== DETAILS

• Added a new config option notes
• If notes is set, the value of notes is set as the annotation on the VirtualMahineConfigSpec
• This will show up in the vSphere Web UI in the notes field, and in the vSphere thick client under Notes: in the Annotations field

== TESTING

• Added a new spec to test the behavior
• rake spec all passes
• rake rubocop doesn't have any more errors than it did before :)

[rylarson]

It looks like RuboCop is failing in CI, but it was already failing. Do I need to add exclusions or fix these RuboCop errors before this can be merged?

[rylarson]

Sorry for all of the commits, the tests were in a pretty broken state when I got to them.

The commit message has details, but we have to make sure that our mock takes a little while to "connect" because Vagrant has some really terrible multithreaded code here: https://github.com/mitchellh/vagrant/blob/master/lib/vagrant/action/builtin/wait_for_communicator.rb#L16

[rylarson]

Is there anything else I need to do to get this merged?

[rylarson]

I merged out from master so there are no conflicts again

[ghost]

Looks like my merging another pull request broke rubocop on this one again. Earlier I disabled some metrics cops so that pull requests would stop breaking from making a module or class one line longer, but I mistakenly made that change in .rubocop_todo.yml instead of .rubocop.yml. I'll make the fix in .rubocop.yml, but then you may have another merge conflict...

[ghost]

After adding vsphere.notes = 'note string' to my Vagrantfile, I just got the same NoPermission error as on #174.

[ghost]

Thanks!

[rylarson]

@michael-brandt-cu

As far as the permissions issue goes, can you make sure that you have the Reconfigure privilege: VirtualMachine.Config.Rename permission?

Ryan