search

nsiregar / pegelinux

Blog aggregator for pegelinux community
https://pegelinux.id
MIT License
10 stars 9 forks source link

Comment written before loging in not submitted #49

Open wildtype opened 6 years ago

wildtype commented 6 years ago

Steps to reproduce

  1. Without logging in, open pegelinux.id.
  2. Visit comments page.
  3. Write comment and submit.
  4. Login form shown. Fill with the right username and password, then login.

Actual condition

  1. Homepage shown after login.
  2. Comment written in step 3 not shown on comment page.

Expected condition

  1. Comment written in step 3 is submitted and shown after login success.

I'm not sure if this is a bug, or just not implemented yet. Feel free to remove the bug label and change this issue into feature suggestion/enhancement.

nsiregar commented 6 years ago

looks like it's not implemented yet, during login process we only catch previous url. we should implement this, it's kinda annoying when you write long comment then gone.

wildtype commented 6 years ago

I changed the label to enhancement. Reference for implementation: https://stackoverflow.com/a/32216213

Seems complicated. What about putting link to login page instead of comment form? Then after logged in, visitor will be redirected back to comments page.