search

nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Updates to Gitignore #102

Closed CivBase closed 9 years ago

CivBase commented 9 years ago

Description: Updated the .gitignore files to support additional development environments (such as PyCharm). Also updated the requirements to include service-identity, which was suggested by twisted on execution.

Reviewer(s): @nskinkel

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 35.89% when pulling c2daccec622da45f6ebfbddf94b28b4669cf8272 on CivBase:master into 039a39e77990cd3ea317edb46e7a40aa8ea2f5cb on nskinkel:master.

nskinkel commented 9 years ago

The .gitignore updates look fine.

service-identity is not needed, though. The TLS certificates used are self signed and are validated through a custom authentication procedure, not the standard from RFC 6125. For more info check out sections 2 and 4.0-4.2 of the tor-spec.txt document.

Can you post the platform you're on and the message Twisted gave if it occurs again? Also, was this an error message or just a suggestion?

Otherwise, if you remove the service-identity addition then I can merge.

CivBase commented 9 years ago

@nskinkel I get pretty much the same message on OSX and Debian. Without the service-identity package, the Debian version says

/home/civbase/virtualenvs/oppy/local/lib/python2.7/site-packages/twisted/internet/_sslverify.py:184: UserWarning: You do not have the service_identity module installed. Please install it from <https://pypi.python.org/pypi/service_identity>. Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification. Many valid certificate/hostname mappings may be rejected.
    verifyHostname, VerificationError = _selectVerifyImplementation()

It appears to just be a suggestion. If it is not actually an issue, I recommend suppressing the message.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 35.89% when pulling 80336d3d06c6b1bf1861ab5c4fdda518901e5e9f on CivBase:master into 039a39e77990cd3ea317edb46e7a40aa8ea2f5cb on nskinkel:master.

nskinkel commented 9 years ago

Ok, merged.

Re Twisted warning:

Yikes, you're right that's an ugly warning. I apparently already had the service-identity package installed for some other reason on my system so I didn't see the warning.

It's a pretty small package (and it really should be baked into Python anyway), so I went ahead and added it as a requirement as you suggested. There doesn't seem to be any other way to stop Twisted from complaining.