search

nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Cell cleanup: dead code #103

Closed CivBase closed 9 years ago

CivBase commented 9 years ago

Description: Removed some dead code I found in cell.py. It is technically executed, but it is also overridden immediately after and does not affect the code in any meaningful way.

Reviewer(s): @nskinkel

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) to 35.9% when pulling 4aedc01f6e8fa82b991ba0f8cf96c3fbd32988ae on CivBase:clean_up_dead_code into 44441db07463583f47d7cc8887d22a0798d7b80d on nskinkel:master.

nskinkel commented 9 years ago

Good catch. I fixed this slightly differently than you did in your PR in 096cf92875, but same idea. I prefer to assign things using meaningful constants where possible to help readers understand how we implement the protocol, so I just did that and removed the struct.calcsize() call entirely.