search

nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Assert statement issue in constructor of util/ExitRequest #106

Closed BradWells closed 9 years ago

BradWells commented 9 years ago

In line 21 of exitrequest.py there is an issue with the assert statement:

assert addr or host and not (addr and host)

This assertion will evaluate to (addr or host), while I believe what you want is

(addr or host) and ! (addr and host)

or more simply

addr ^ host
nskinkel commented 9 years ago

Yep you're right, good catch. Tagged as a bug.

Want to make a pull request for it?

nskinkel commented 9 years ago

Fixed a while ago (forgot to close bug).