nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

socks.py - Error Handling `SOCKSProtocol` #11

Closed dwtj closed 9 years ago

dwtj commented 10 years ago

I need to figure out how the protocol gets wound-down when various protocol errors occur, in particular, when malformed or unexpected messages come from the client. If nothing else, I need to add some logging when the errors are discovered. There are a few kinds of errors that may happen in the protocol's lifetime.

Also, I need to figure out how to kill the protocol if a timeout occurs.

I also remember from the SOCKS 5 RFC mentioning some context in which the SOCKS server is supposed to send a response within 10 seconds of some error occurring. I will need to look this up.

nskinkel commented 9 years ago

Implemented as of 508d6b9e9a