search

nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Remove `recognized` from the public interface of relay cells. #45

Closed dwtj closed 9 years ago

dwtj commented 9 years ago

We may or may not want to have recognized be part of the public interface of a relay cell's constructor. If we do keep it, it should at least be a default argument.

All relay cells which we create will have their recognized field set to zero. However, we may receive relay cells which (erroneously) have their recognized field set to something besides zero.

Where should we check whether a received relay cell is recognized. Probably in the OnionCircuit after a cell has been created using from_bytes().

dwtj commented 9 years ago

As of commit 63251f1, recognized and other relay header things are more hidden in interface of the constructor.