nskinkel / oppy

A Tor client (onion proxy) implementation in Python
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Make Crypto Code `signing_key_to_sha1()` #56

Closed dwtj closed 9 years ago

dwtj commented 9 years ago

Various places in the crypto code turn signing keys to sha1 hashes using an unclear trick. Start using the signing_key_to_sha1() function instead.

dwtj commented 9 years ago

While refactoring stuff, I put this function to use in one or two places, but I bet that there are more.

Also, I feel like signing_key_to_sha1() should be moved from util.tools to crypto.util.

nskinkel commented 9 years ago

Yea, basically anytime we need to send a signing_key, we need to call this function. It's not really a crypto thing, but it can go there if you think it makes sense.