Add NPC#say and tests - Githubissues

nskins / goby

Command-line role-playing game framework

MIT License

122 stars 56 forks source link

Add NPC#say and tests #114

Closed jamesball27 closed 7 years ago

jamesball27 commented 7 years ago

Resolve issue #112

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling c7782bcab9dbc0d4e1bda2974a853b558034bdcf on jamesball27:master into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling a8baa9ef0e7c06fee7ebd434712ddffc5a9718cc on jamesball27:master into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

nskins commented 7 years ago

@jamesball27 - Cool! This looks good. However, please remove your second commit from this pull so that I can consider these features separately. I see that you've made a pull request for the other feature so I'll check that out shortly.

jamesball27 commented 7 years ago

Sorry about that! I just removed the other commit.

nskins commented 7 years ago

Thanks. Sorry to be picky, but could you send the pull request from a different branch (not master). Your master branch should be the same as mine (origin/base) and I don't want anything funky happening if my master changes before we merge this.

nskins commented 7 years ago

Hi @jamesball27. You currently have three open pull requests with requested changes on each. Are you still working? If so, let's stick to one issue at a time. I'd like to merge this one first, then #115, then #118. Please let me know if you are still willing to make the changes. If not, I will re-open the issues.

jamesball27 commented 7 years ago

Sorry for the delay, I just sent a new PR from a separate branch in #119