Refactor all Couple.new(a, b) to Couple[a, b]

nskins / goby

Command-line role-playing game framework

MIT License

122 stars 56 forks source link

Refactor all Couple.new(a, b) to Couple[a, b] #115

Closed jamesball27 closed 7 years ago

jamesball27 commented 7 years ago

Resolve #113

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling dd9794332ab1a714d7a90028076617b510547bda on jamesball27:couple-refactor into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

nskins commented 7 years ago

@jamesball27 - Thanks! Fixing this one is a BIG help. Actually, I really want to make it as short as possible, so could you change the name of Couple to just "C"? Also, in the documentation, lowercase the name "Couple" to "couple" wherever it appears (I don't know if it does). You can change the wording too if it might help aid the meaning.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 6ceeb1ca1d776d625bb021887563a7d4fb2792c9 on jamesball27:couple-refactor into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

nskins commented 7 years ago

Oops. I should've let you know that whenever Couple appears as a type (@param/@return), I wanted it to be rewritten as "C". My bad, so I am sending a pull request to your fork with the update.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 1ab06da91c3563f546809106651fe34cc4a880a0 on jamesball27:couple-refactor into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

nskins commented 7 years ago

Great job! :+1: