Refactor specs to use #let instead of instance variables

nskins / goby

Command-line role-playing game framework

MIT License

122 stars 56 forks source link

Refactor specs to use #let instead of instance variables #118

Closed jamesball27 closed 7 years ago

jamesball27 commented 7 years ago

Resolve #116.

A few of the I/O tests require use of let! for some reason, but everything should be working properly.

nskins commented 7 years ago

I have (nearly) fixed #117, and I would like to push that to master before we merge this. At that time, I may need to resolve a merge conflict (if one arises), so I may send a pull request to your fork. Thanks for your contribution and patience!

Also, please look into why you needed to use let! sometimes as I am not comfortable merging unless we know why. I'd like to know more than "for some reason."

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 30930d8980e197655c462ce5241afc8993372e92 on jamesball27:spec-refactor into 4bcf2a2696696e6e5c70063738863886a74ec382 on nskins:master.

coveralls commented 7 years ago

Coverage decreased (-66.8%) to 33.215% when pulling 6f1edf60bda75a81fa74e970514f14612d6df3b9 on jamesball27:spec-refactor into 4473fe0bbeca3bb9f4a1e3f4e3cfe8b3f8aa3772 on nskins:master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 58bfc52a5c93cda18cf3c163af6d1da5f8a33337 on jamesball27:spec-refactor into 4473fe0bbeca3bb9f4a1e3f4e3cfe8b3f8aa3772 on nskins:master.

nskins commented 7 years ago

Thanks a lot for all your help!