search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Tile description should not add newlines to the end #128

Closed nskins closed 6 years ago

nskins commented 6 years ago

In #describe_tile of world_command.rb, the output of the Tile's description is automatically appended with two newlines, but this is the only place in the framework where it's done. Users probably won't expect or like that. Just remove the two newlines and update the scaffold project to include newlines in the Grass description. You should also make sure a Tile with no description does not display extraneous newlines.

Make the pull against the 0.2.1 branch.

pokharelonrails commented 6 years ago

@nskins can I take a look?

nskins commented 6 years ago

@pokharelonrails Yes, of course!

SwArMD0 commented 6 years ago

@nskins I would like to give it a crack at the ol' bat. Unless it was already solved by @pokharelonrails

nskins commented 6 years ago

Hi @Hedion. Sorry, this issue isn't open right now since I haven't had a chance to review the pull request from @pokharelonrails. Thanks for your interest, and please stay tuned for more opportunities to contribute!

nskins commented 6 years ago

Closed by #130.