search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Remove events variable assignment #135

Closed mjvcallibrity closed 6 years ago

mjvcallibrity commented 6 years ago

This PR removes a superfluous variable assignment in Goby::WorldComman#describe_tile. A variable "events" was being assigned, but not used in the #describe_tile function. This commit removes that variable assignment as a matter of keeping the code clean.

nskins commented 6 years ago

Hi @mjvcallibrity - thanks a lot for the pull request.

To say "A iff B" is to say that A is true if B is true, and vice versa. It's logically stronger than "A if B," which only covers the former statement. Change that part back to "iff" (or "if and only if"). You'll need to update that in your continue_game? function doc as well as the run_turn function doc.

The type specified in the parameter documentation of your continue_game? function should be String, not Input. The first word after the type must also match the parameter name (in this case "input").

Finally, you'll need to merge the 0.2.1 branch into your branch and change your pull request to target that branch. I do not accept pull requests directly to master.

mjvezzani commented 6 years ago

Hey,

Many thanks for giving a clear explanation on the "A iff B" statement. I (obviously) didn't know about that before. I'll also be sure to update the parameter documentation on continue_game?, and branch of the 0.2.1 branch.