search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Remove var assignment and add private method #137

Closed mjvezzani closed 6 years ago

mjvezzani commented 6 years ago

This commit removes a superfluous variable assignment in world_command.rb.

It also adds a new private variable continue_game? into driver.rb. The method is responsible for checking to see if the user has typed the "quit" command. It helps increase human readability of the code.

mjvezzani commented 6 years ago

Hey @nskins. This is mjvcallibrity, but I'm now using my private github repo instead of the one I use for work. I'll try to stick to using this one when working on this project.

I followed your suggestions and made my changes of the 0.2.1 branch. This pull request is a result of your suggestions. Thanks!

nskins commented 6 years ago

Document the return value of continue_game? and we should be all set here.

mjvezzani commented 6 years ago

Updated!

mjvezzani commented 6 years ago

@nskins Just a bump that I believe this PR is all set and ready for merging.

nskins commented 6 years ago

All set! Thanks!