search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Tiles and Maps Tutorial #138

Closed mjvezzani closed 6 years ago

mjvezzani commented 6 years ago

This pull request adds new directories (/documentation/tutorials/) to hold documentation around tutorials and getting started markdown documents. It also includes a new tutorial on getting started with tiles and maps.

mjvezzani commented 6 years ago

Not sure if this is actually supposed to be a pull request against the 0.2.0 branch or the 0.2.1 branch. Just let me know if I need to switch it.

nskins commented 6 years ago

Cool! This looks really nice. I'll do an in-depth review sometime this week.

For now, change the location from /documentation/tutorials/ to /tutorials/ since we already have a /doc/ directory that generates when you run yardoc.

nskins commented 6 years ago

Hey @mjvezzani, I added some comments to your commit. Resolve those problems and let me know if you have questions. Overall, I really like how you started this. It was really clever to implement Grass checking its passable trait to determine the graphic. Good work!

mjvcallibrity commented 6 years ago

@nskins Thanks for the feedback. Sorry it fell under my radar as my inbox was subject to the deluge of daily email and somehow I missed this. I'll make the suggested updates and get them pushed up.

mjvcallibrity commented 6 years ago

Alright. I went ahead and got those changes in. I, based on the comment you made about project initialization, I pulled out the last section, recognizing that it probably would be more appropriate to put that content in a "Getting up and running" tutorial that comes before this one.

nskins commented 6 years ago

Content looks good. Change the file location to /tutorials and we'll be all set here.

mjvcallibrity commented 6 years ago

Okay. Now I think it's done. :)

nskins commented 6 years ago

Thanks a lot!!