nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Change Escape Algorithm To Be Based On Agility #67

Closed schuyler4 closed 7 years ago

schuyler4 commented 7 years ago

I changed the escape algorithm to be based on agility like suggested on issue #65.

nskins commented 7 years ago

Hi @schuyler4. In order to prevent code duplication, you should use the function player_first? provided in player.rb to determine if the escape is successful. Also, could you rename that player_first? to sample_agilities, please? Let me know if you have any questions.

nskins commented 7 years ago

Looks good! Thanks!