search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Add conditional to print_status #79

Closed ryancoopersmith closed 7 years ago

ryancoopersmith commented 7 years ago

I hope this works... As I said this is my first open source contribution so very I'm excited! If I need to fix anything please let me know.

nskins commented 7 years ago

Hi @ryancoopersmith, thanks for opening this pull request! There is one small change I will need you to make: when the battle commands are empty, there still needs to be an empty line (via "\n") at the end of print_status. This can be done by printing the newline character (at line 215) irregardless of the result of the surrounding conditional statement. Please let me know if you have questions!

EDIT: Note that the required newline character is already there when the battle commands are not empty. You will need to fix the case when the battle commands are empty.

ryancoopersmith commented 7 years ago

I should have fixed this. Thanks for the opportunity to let me contribute to your project!

nskins commented 7 years ago

Awesome! Looks good... and thank YOU for contributing!