search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Argument in update_map #81

Closed shyam12860 closed 7 years ago

shyam12860 commented 7 years ago

Fixes #62

nskins commented 7 years ago

@shyam12860 Hey! I like the idea for the default argument! Here's a couple changes I need you to make:

  1. Instead of keyword arguments, use the Ruby 1.9 version of default arguments. Keyword arguments are better when there are lots of arguments (like in the Player constructor), and object creation might only require a few custom arguments.

  2. Fix the indentation in the tests that you added. Each successive block should be indented by exactly 1 tab = 2 spaces.

Thanks!

shyam12860 commented 7 years ago

Hey! Good pointers there. I've committed and squashed the new commits into the old one. Should be fine now!

nskins commented 7 years ago

Great. Thanks for contributing!