search

nskins / goby

Command-line role-playing game framework
MIT License
122 stars 56 forks source link

Abstract all input into one function #93

Closed nskins closed 7 years ago

nskins commented 7 years ago

Currently, we use player_input (util.rb) for some user input, but we should use it for all input. One argument for this function could be a boolean that, when set, would return a lowercase string (would be important for y/n questions, #53, etc.). Another argument would be the prompt, when required. For instance, on the world map, we use >. Also, sometimes there is no prompt. Include tests.

hd719 commented 7 years ago

Hello there! I am new to open source and I would like to contribute to this project.

nskins commented 7 years ago

Hi @hd719, thanks for your interest! Would you like to work on this issue, in particular?

rdavid1099 commented 7 years ago

Hey @nskins, sorry about going dark there for a bit, I had some things come up. I have more time now. If @hd719 isn't going to tackle this, I can take care of it. Otherwise, feel free to tag me in some issues and shovel some work my way.

nskins commented 7 years ago

Hey @rdavid1099, yes, you can work on this issue. Please send your pull request to the player-input branch and let me know if you have questions.

hd719 commented 7 years ago

This issue is all yours @rdavid1099!

rdavid1099 commented 7 years ago

Rock on. Thanks @hd719 and @nskins

rdavid1099 commented 7 years ago

@nskins PR made for this issue.