search

nsls-ii-forge / pycentroids-feedstock

[ARCHIVED] Please use the conda-forge feedstock. A conda-smithy repository for pycentroids.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Fix Windows builds #2

Open mrakitin opened 4 years ago

mrakitin commented 4 years ago

The log of the failed Windows build can be found here. Here is the specific issue:

  -- Building for: Visual Studio 15 2017 Win64
  CMake Error at CMakeLists.txt:2 (project):
    Generator

      Visual Studio 15 2017 Win64

    does not support platform specification, but platform

      x64

    was specified.

  -- Configuring incomplete, errors occurred!

@stuwilkins, any thoughts about it?

mrakitin commented 4 years ago

Building Windows packages was excluded in https://github.com/nsls-ii-forge/pycentroids-feedstock/pull/1.

stuwilkins commented 4 years ago

No.. but googling found this:

https://stackoverflow.com/questions/48624415/how-to-fix-cmake-error-in-cmakelists-txt-generator-nmake-makefiles-does-not-sup

mrakitin commented 4 years ago

OK, thanks, that's what I found yesterday too. I will see how it can be done with the existing infrastructure. Maybe a different combination of dependencies will be needed for Windows.

mrakitin commented 4 years ago

@mariusvniekerk, @isuruf, @cj-wright, could you please let us know if you observed the issue described above and know how to fix it? Is it something which can be solved upstream (e.g., in conda-forge-pinning)?

isuruf commented 4 years ago

Why do you think this is a conda-forge issue? Have you asked the upstream author why they added https://github.com/NSLS-II/centroids/blob/master/setup.py#L63 ?

mrakitin commented 4 years ago

Thanks @isuruf, we will discuss that flag. I am not claiming that's a conda-forge issue, just wanted to get your feedback as you may have seen such issues before. Thanks for looking into that!

stuwilkins commented 4 years ago

@mrakitin do you want to try removing that flag, it was just copied from the pybind example

mrakitin commented 4 years ago

Yes, we can try and see how it goes. I assume for Windows builds we need commands like <executable> /<option> /<another option> ....